Michael Haggerty wrote:
[...]
> @@ -722,9 +667,9 @@ static int get_cmd_result(struct imap_store *ctx, struct imap_cmd *tcmd)
> }
>
> if (!strcmp("NAMESPACE", arg)) {
> - imap->ns_personal = parse_list(&cmd);
> - imap->ns_other = parse_list(&cmd);
> - imap->ns_shared = parse_list(&cmd);
> + skip_list(&cmd);
> + skip_list(&cmd);
> + skip_list(&cmd);
This codepath would only be triggered if we emit a NAMESPACE command,
right? If I am understanding correctly, a comment could make this
less mystifying:
/* rfc2342 NAMESPACE response. */
skip_list(&cmd); /* Personal mailboxes */
skip_list(&cmd); /* Others' mailboxes */
skip_list(&cmd); /* Shared mailboxes */
Though that's probably academic since hopefully this if branch
will die soon. :)
The rest of the patch is clear and pleasant and also looks correct.
With the above change,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html