Re: [PATCH v3 03/31] Add parse_pathspec() that converts cmdline args to struct pathspec

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jan 14, 2013 at 7:05 AM, Martin von Zweigbergk
<martinvonz@xxxxxxxxx> wrote:
> On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote:
>> +static void parse_pathspec(struct pathspec *pathspec,
>> +                          unsigned magic_mask, unsigned flags,
>> +                          const char *prefix, const char **argv)
>> +{
>> +       struct pathspec_item *item;
>> +       const char *entry = *argv;
>> ...
>> +       for (i = 0; i < n; i++) {
>> +               const char *arg = argv[i];
>
> Nit: "*argv" was assigned to "entry" above. Reassign that variable instead?

Yeah. Thanks for catching.
-- 
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]