On Sun, Jan 13, 2013 at 4:35 AM, Nguyễn Thái Ngọc Duy <pclouds@xxxxxxxxx> wrote: > +static void parse_pathspec(struct pathspec *pathspec, > + unsigned magic_mask, unsigned flags, > + const char *prefix, const char **argv) > +{ > + struct pathspec_item *item; > + const char *entry = *argv; > ... > + for (i = 0; i < n; i++) { > + const char *arg = argv[i]; Nit: "*argv" was assigned to "entry" above. Reassign that variable instead? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html