On Wed, Dec 19, 2012 at 11:06:02PM -0500, Jeff King wrote: > > I don't think we can make a change in simple_length. It gets used not > > only for pathspecs, but also for parsing exclude patterns, which I do > > not think should be affected by this option. > > Our test suite wouldn't catch such a misfeature, of course, because the > feature is not turned on by default. But I found it instructive to run > all of the tests with GIT_LITERAL_PATHSPECS on. There are failures, of > course, but by inspecting each failure you can see that it is an > intended effect of the patch (i.e., each tries to use a wildcard > pathspec, which no longer works). > > When you suggested changing common_prefix, I ran such a test both with > and without the change[1] and confirmed that it did not change the set > of failure sites. I did not try it, but I suspect running such a test > with the tip of pu would reveal new failures in the .gitignore tests. I just tried it, and indeed, running the test suite with this patch: diff --git a/t/test-lib.sh b/t/test-lib.sh index 256f1c6..1c43593 100644 --- a/t/test-lib.sh +++ b/t/test-lib.sh @@ -102,6 +102,9 @@ export EDITOR export GIT_COMMITTER_EMAIL GIT_COMMITTER_NAME export EDITOR +GIT_LITERAL_PATHSPECS=1 +export GIT_LITERAL_PATHSPECS + # Add libc MALLOC and MALLOC_PERTURB test # only if we are not executing the test with valgrind if expr " $GIT_TEST_OPTS " : ".* --valgrind " >/dev/null || produces many more failures on "pu" than it does on jk/pathspec-literal. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html