On Thu, Dec 20, 2012 at 3:34 AM, Jeff King <peff@xxxxxxxx> wrote: > Part of me thinks this is just gross, because ":(noglob)" is the right > solution. But after spending a few hours trying it this morning, there > is a ton of refactoring required to make it work correctly everywhere > (although we could die() if we see it in places that are not using > init_pathspec, so at least we could say "not supported yet" and not just > silently ignore it). Yep, I'm still half way to converting everything to the new pathspec code. I'm not there yet. And things like this probably better goes with a config key or command line option, appending :(noglob) to every pathspec item is not pleasant. :(icase) may go the same way. > So I think this is a nice, simple approach for sites that want it, and > noglob magic can come later (and will not be any harder to implement as > a result of this patch). Any chance to make use of nd/pathspec-wildcard? It changes the same code path in match_one. If you base on top of nd/pathspec-wildcard, all you have to do is assign nowildcard_len to len (i.e. no wildcard part). -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html