On Mon, Dec 17, 2012 at 12:03:40PM -0800, Junio C Hamano wrote: > > So no, I do not think you can cover every conceivable case. But having > > git-log respect --color and the usual color.* variables for this feature > > seems like the only sane default. It makes the easy cases just work, and > > the hard cases are not any worse off (and they may even be better off, > > since the script can manipulate --color instead of rewriting their > > format strings, but that is a minor difference). > > OK, care to reroll the one with your patch in the other message > squashed in, possibly with fixes to the test (the result should now > honor --color={always,never}, I think)? Here it is. It was easier to just skip using test_format, so it did not need to be touched. I broke its cleanups out into a separate patch. [1/2]: t6006: clean up whitespace [2/2]: log --format: teach %C(auto,black) to respect color config -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html