On Sat, Dec 01, 2012 at 01:31:23PM +0100, Erik Faye-Lund wrote: > >> One thing you might want to mention is that the fgetc() handling is not > >> thread-safe, and intentionally so: if two threads read from the same > >> console, we are in trouble anyway. > > > > That makes sense to me, but I'm confused why it is part of mingw_fgetc, > > which could in theory read from arbitrary streams, no? It it is not > > necessarily a console operation at all. I feel like I'm probably missing > > something subtle here... > > I did add an early out for the non-console cases. Is this what you're > missing, perhaps? Oops, yes. That is exactly what I was missing. :) Sorry for the noise. -Peff -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html