On Fri, Nov 30, 2012 at 7:11 PM, Jeff King <peff@xxxxxxxx> wrote: > On Fri, Nov 30, 2012 at 06:58:11PM +0100, Johannes Schindelin wrote: > >> Hi, >> >> On Tue, 13 Nov 2012, Erik Faye-Lund wrote: >> >> > Set a control-handler to prevent the process from terminating, and >> > simulate SIGINT so it can be handled by a signal-handler as usual. >> >> One thing you might want to mention is that the fgetc() handling is not >> thread-safe, and intentionally so: if two threads read from the same >> console, we are in trouble anyway. > > That makes sense to me, but I'm confused why it is part of mingw_fgetc, > which could in theory read from arbitrary streams, no? It it is not > necessarily a console operation at all. I feel like I'm probably missing > something subtle here... I did add an early out for the non-console cases. Is this what you're missing, perhaps? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html