On Wed, Nov 28, 2012 at 9:03 AM, Felipe Contreras <felipe.contreras@xxxxxxxxx> wrote: > On Wed, Nov 28, 2012 at 8:36 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: >> Christian Couder <chriscool@xxxxxxxxxxxxx> writes: >> >>> All the python scripts except contrib/svn-fe/svnrdump_sim.py >>> start with "#!/usr/bin/env python". >>> >>> This patch fix contrib/svn-fe/svnrdump_sim.py to do the same. >> >> I suspect you need a bit more than that. >> >> $ make git-p4 >> $ diff -u git-p4.py git-p4 >> >> shows you how we tell the scripts how to find their interpreters >> (that way, there is no need to rely on the existence of >> /usr/bin/env). > > That works if somebody managed to export PYTHON_PATH, which very very > often is not the case for me. Yeah, and even if PYTHON_PATH is used, in t9020-remote-svn.sh, svnrdump.py is used as is. So if your python is not /usr/bin/python, you cannot just add something to $PATH to pass the test. Best regards, Christian. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html