Lars Hjemli wrote:
On 1/3/07, Marco Costalba <mcostalba@xxxxxxxxx> wrote:
On 1/3/07, Lars Hjemli <hjemli@xxxxxxxxx> wrote:
> On 1/3/07, Marco Costalba <mcostalba@xxxxxxxxx> wrote:
> > - one blank line
> > - zero or one line with log title
> > - zero or more lines with log message
> > - a terminating '\0'
>
> I think the should be:
> -zero or more blank lines
Isn't it zero or _one_ blank line? Why more then one? would be it
useful? surely is slower to parse.
My point is just that the log message is unformatted. There is nothing
stopping you from
adding blank lines at the start of the message.
But then I tested it, and it seems as 'git-commit' strips off any
leading blank lines (but git-commit-tree does not). So expecting one
blank _might_ be good enough.
Other scm's from which we can import repositories have no such
mechanisms though. It would be nice to have this functionality in
rev-list. I'm looking into it at the moment.
> -zero or more blank lines
Why? this is necessary only to disambiguate muti (non blank) lines
titles, but as Junio pointed out distinction between log title and log
message is only in the Porcelain, not encoded in git. So the Porcalain
is going to show _one_line title if any an the remaining stuff in the
log message.
Well, if the porcelain chooses to do so, it probably is ok. But I
think the parsing/presentation of the log title/message would be more
correct/better formatted if the parser is more "adaptive" to the
content.
I disagree. If the title spans over more than one line, it's most likely
because it's too long to fit in one, in which case it won't look good
(or even be viewable in qgit / gitk) when printed anyways.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html