Marco Costalba wrote:
On 1/3/07, Lars Hjemli <hjemli@xxxxxxxxx> wrote:
On 1/3/07, Marco Costalba <mcostalba@xxxxxxxxx> wrote:
> - one blank line
> - zero or one line with log title
> - zero or more lines with log message
> - a terminating '\0'
I think the should be:
-zero or more blank lines
Isn't it zero or _one_ blank line? Why more then one? would be it
useful? surely is slower to parse.
I've imported a repository from CVS to git (the nagiosplugin repo),
where one author consistently put an empty line before the "commit
subject". I'm fairly certain this is done by the tool he uses (some GUI
thing, no doubt).
I'm currently looking into stripping optional empty lines appearing
postheaders-prebody from rev-list output, as it completely fudges qgit
and gitk viewing alike. Good thing the author in question only does
translations and no code work, or I'd be screaming with frustration
trying to figure out which commit does what. Mind you, CVS's lack of
forensic tools doesn't exactly inspire the clear and concise commit
messages we see in git, but still...
-zero or more non-blank lines with log title
multi lines titles are allowed? never saw one of them.
They aren't disallowed. The log message part only by convention consists
of a title line followed by a blank and then the message body. It's
entirely possible to just start writing the message straight off, or put
any number of blank lines wherever.
-zero or more blank lines
Why? this is necessary only to disambiguate muti (non blank) lines
titles, but as Junio pointed out distinction between log title and log
message is only in the Porcelain, not encoded in git. So the Porcalain
is going to show _one_line title if any an the remaining stuff in the
log message.
Sensible. There's no (reliable) way of knowing if the first line with
text on is actually a title or just the start of a 25-line sentence, or
even the signoff line, or completely empty.
--
Andreas Ericsson andreas.ericsson@xxxxxx
OP5 AB www.op5.se
Tel: +46 8-230225 Fax: +46 8-230231
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html