On 11/20/2012 11:28 AM, Felipe Contreras wrote: > On Tue, Nov 20, 2012 at 8:56 AM, Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> wrote: > >> --- a/git-send-email.perl >> +++ b/git-send-email.perl >> @@ -925,8 +925,11 @@ sub quote_subject { >> sub sanitize_address { >> my ($recipient) = @_; >> >> + my $local_part_regexp = qr/[^<>"\s@]+/; >> + my $domain_regexp = qr/[^.<>"\s@]+(?:\.[^.<>"\s@]+)+/; >> + >> # remove garbage after email address >> - $recipient =~ s/(.*>).*$/$1/; >> + $recipient =~ s/^(.*?<$local_part_regexp\@$domain_regexp>).*/$1/; > > I don't think all that extra complexity is warranted, to me > s/(.*?>)(.*)$/$1/ is just fine. > It's intentionally left without the at-sign so one can send mail to a local account as well as remote ones. Very nifty when debugging, and when one wants to preview outgoing emails. -- Andreas Ericsson andreas.ericsson@xxxxxx OP5 AB www.op5.se Tel: +46 8-230225 Fax: +46 8-230231 Considering the successes of the wars on alcohol, poverty, drugs and terror, I think we should give some serious thought to declaring war on peace. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html