Krzysztof Mazur <krzysiek@xxxxxxxxxxxx> writes:
> On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote:
>> Hi guys,
>>
>> for whatever reason my git has started acting up with
>> stable@xxxxxxxxxxxxxxx addresses. It doesn't manage to extract a valid
>> adress from the string:
>>
>> Cc: <stable@xxxxxxxxxxxxxxx> # v3.4 v3.5 v3.6
>>
>> Removing the comment at the end of the line makes things work again. I
>> do remember, however, seeing this working since few weeks back I sent a
>> mail to stable (in fact the same one I'm using to test), so this could
>> be related to some perl updates, who knows ?!?
>
> You probably just installed Email::Valid package.
>
> The current git-send-email works a little better and just prints an error:
>
> W: unable to extract a valid address from: <stable@xxxxxxxxxxxxxxx> #v3.4 v3.5 v3.6
>
>
> This patch should fix the problem, now after <email> any garbage is
> removed while extracting address.
>
> diff --git a/git-send-email.perl b/git-send-email.perl
> index 5a7c29d..bb659da 100755
> --- a/git-send-email.perl
> +++ b/git-send-email.perl
> @@ -828,7 +828,7 @@ sub extract_valid_address {
> # check for a local address:
> return $address if ($address =~ /^($local_part_regexp)$/);
>
> - $address =~ s/^\s*<(.*)>\s*$/$1/;
> + $address =~ s/^\s*<(.*)>.*$/$1/;
> if ($have_email_valid) {
> return scalar Email::Valid->address($address);
> } else {
Given that the problematic line
Stable Kernel Maintainance Track <stable@xxxxxxxxxxxxxxx> # vX.Y
is not even a valid e-mail address, doesn't this new logic belong to
sanitize_address() conceptually?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html