On Wed, Oct 31, 2012 at 3:13 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Felipe Contreras wrote: > >> It's all fun and games to write explanations for things, but it's not >> that easy when you want those explanations to be actually true, and >> corrent--you have to spend time to make sure of that. > > That's why it's useful for the patch submitter to write them, asking > for help when necessary. > > As a bonus, it helps reviewers understand the effect of the patch. > Bugs averted! Yeah, that would be nice. Too bad I don't have that information, and have _zero_ motivation to go and get it for you. > [...] >> Either way, if obvious fixes that are one-liners require an essay for >> you, I give up. > > I guess it is fair to call a reasonable subject line plus a couple of > sentences an essay. Yes, obvious fixes especially require that, since > the bug caused by an obvious fix is one of the worst kinds. Yes, I've written essays for one-line fixes, in the Linux kernel, where details matter, and things are not so obvious. This is not the case here. This is as obvious and simple as things get. If there was a problem with it, somebody would have found it by now. Let not the perfect be the enemy of the good. Or do. Up to you. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html