Felipe Contreras wrote: > On Tue, Oct 30, 2012 at 5:46 AM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > > Felipe Contreras wrote: >>> No reason to use the full path in case this is used externally. >>> >>> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> >> >> "No reason not to" is not a reason to do anything. What symptoms does >> this prevent? Could you describe the benefit of this patch in a >> paragraph starting "Now you can ..."? > > ./test-lib.sh: line 394: > /home/felipec/dev/git/t/test-results//home/felipec/dev/git/contrib/remote-hg/test-21865.counts: > No such file or directory Ok, so a description for this patch is test: use test's basename to name results file Running a test using its full path produces an error: $ ~/dev/git/contrib/remote-hg/test-21865.sh [...] ./test-lib.sh: line 394: /home/felipec/dev/t/\ test-results//home/felipec/dev/git/contrib/remote-hg/\ test-21865.counts: No such file or directory In --tee and --valgrind modes we already use the basename to name the .out and .exit files; this patch teaches the test-lib to name the .counts file the same way. That is still not enough to tell if it is a good change, though. Should the test results for contrib/remote-hg/test-* be included with the results for t/t*.sh when I run "make aggregate-results"? Before 60d02ccc, git-svn had its own testsuite under contrib/, with glue in contrib/git-svn/t/lib-git-svn.sh to use test-lib --- maybe that code could provide some inspiration for questions like these. Hope that helps, Jonathan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html