(actually cc-ing the git list this time. Sorry for the noise, all.) Felipe Contreras wrote: > [Subject: [PATCH v2 2/4] fast-export: fix comparisson in tests] > > First the expected, then the actual, otherwise the diff would be the > opposite of what we want. Spelling: s/comparisson/comparison/. Semantics: this isn't actually fixing anything --- it's a cosmetic thing. It would be clearer to say: fast-export test: swap arguments to test_cmp This way if diff output is produced, it describes how the actual output differs from what was expected rather than the other way around. > Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> For what it's worth, with amended message, Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx> Patch left unsnipped because it hadn't hit the list. > --- > t/t9350-fast-export.sh | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/t/t9350-fast-export.sh b/t/t9350-fast-export.sh > index 3e821f9..49bdb44 100755 > --- a/t/t9350-fast-export.sh > +++ b/t/t9350-fast-export.sh > @@ -303,7 +303,7 @@ test_expect_success 'dropping tag of filtered out object' ' > ( > cd limit-by-paths && > git fast-export --tag-of-filtered-object=drop mytag -- there > output && > - test_cmp output expected > + test_cmp expected output > ) > ' > > @@ -320,7 +320,7 @@ test_expect_success 'rewriting tag of filtered out object' ' > ( > cd limit-by-paths && > git fast-export --tag-of-filtered-object=rewrite mytag -- there > output && > - test_cmp output expected > + test_cmp expected output > ) > ' > > @@ -351,7 +351,7 @@ test_expect_failure 'no exact-ref revisions included' ' > ( > cd limit-by-paths && > git fast-export master~2..master~1 > output && > - test_cmp output expected > + test_cmp expected output > ) > ' > > -- > 1.8.0 -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html