Felipe Contreras wrote:
> Setting commit to commit is a no-op.
Wrong description. This should say:
The code uses the idiom of assigning commit to itself to quench a
"may be used uninitialized" warning. Luckily at least modern
versions of gcc do not produce that warning here, so we can drop
the self-assignment.
This makes the code clearer to human beings, makes static
analyzers that do not know that idiom happier, and means that
if the code some day evolves to use this variable uninitialized
then we will catch it.
> Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx>
With that change, for what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@xxxxxxxxx>
Patch left unsnipped since it doesn't seem to have hit the list.
> ---
> builtin/fast-export.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/builtin/fast-export.c b/builtin/fast-export.c
> index 12220ad..065f324 100644
> --- a/builtin/fast-export.c
> +++ b/builtin/fast-export.c
> @@ -483,7 +483,7 @@ static void get_tags_and_duplicates(struct object_array *pending,
> for (i = 0; i < pending->nr; i++) {
> struct object_array_entry *e = pending->objects + i;
> unsigned char sha1[20];
> - struct commit *commit = commit;
> + struct commit *commit;
> char *full_name;
>
> if (dwim_ref(e->name, strlen(e->name), sha1, &full_name) != 1)
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html