> From: Jeff King [mailto:peff@xxxxxxxx] > Sent: Thursday, October 25, 2012 12:49 PM > To: Joachim Schmitz > Cc: git@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fix 'make test' for HP NonStop > > On Thu, Oct 25, 2012 at 12:21:44PM +0200, Joachim Schmitz wrote: > > > > > + # for 'make test' > > > > + # some test don't work with /bin/diff, some fail with /bin/tar > > > > + # some need bash, and some need ${prefix}/bin in PATH first > > > > + SHELL_PATH=${prefix}/bin/bash > > > > + SANE_TOOL_PATH=${prefix}/bin > > > > > > This feels a little too specific to go in our Makefile. Do we have any > > > reason to think that where you are installing git is going to be the > > > same place you have bash and other sane tools? Wouldn't this mean that > > > things work when you run "make" but mysteriously break when you run > > > "make prefix=/my/local/install/of/git"? > > > > Well, "make" won't break (I think), but "make test" very well might. > > Sure. > > > Well, so far all OpenSource packages ported to HP NonStop (at least > > the ones on ituglib.connect-community.org) use prefix=/usr/local and > > there is no intention to change that. > > But then I would think using /usr/local would be the sane thing to put > there, if that is the closest to "standard" for your platform. OK, yes, hardcoding /usr/local seems OK too. Would I need to re-roll? Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html