> From: Jeff King [mailto:peff@xxxxxxxx] > Sent: Thursday, October 25, 2012 11:58 AM > To: Joachim Schmitz > Cc: git@xxxxxxxxxxxxxxx > Subject: Re: [PATCH] fix 'make test' for HP NonStop > > On Mon, Oct 22, 2012 at 04:30:17PM +0200, Joachim Schmitz wrote: > > > + # for 'make test' > > + # some test don't work with /bin/diff, some fail with /bin/tar > > + # some need bash, and some need ${prefix}/bin in PATH first > > + SHELL_PATH=${prefix}/bin/bash > > + SANE_TOOL_PATH=${prefix}/bin > > This feels a little too specific to go in our Makefile. Do we have any > reason to think that where you are installing git is going to be the > same place you have bash and other sane tools? Wouldn't this mean that > things work when you run "make" but mysteriously break when you run > "make prefix=/my/local/install/of/git"? Well, "make" won't break (I think), but "make test" very well might. Well, so far all OpenSource packages ported to HP NonStop (at least the ones on ituglib.connect-community.org) use prefix=/usr/local and there is no intention to change that. A few (bash, vim, coreutils, tar, gzip, bzip2) get delivered with the system meanwhile (rather than having to be downloaded and installed by the customer) and live in /usr/corutiles. Still more are needed (e.g. diff , make). The next lines in my patch cater for that, it is missing though an automatic switch. Such a switch would be possible, using 'uname -r' and 'uname -v', but pretty convoluted Pseudo code: If (`uname -r` = J06 && `uname -v` >= 14) || (`uname -r`= H06 && `uname -v` >= 25) SHELL_PATH=/usr/coreutils/bin/bash SANE_TOOL_PATH=/usr/coreutils/bin:${prefix}/bin else SHELL_PATH=${prefix}/bin/bash SANE_TOOL_PATH=${prefix}/bin endif I didn't deem it worth the effort. As mentioned it'd most likely still need stuff from /usr/local/bin And someone wanting prefix somewhere else could still do PATH=/usr/local/bin:$PATH make prefix=/my/local/install/of/git And so find what's need in either the 1st or 2nd path of PATH Bye, Jojo -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html