Jeff King <peff@xxxxxxxx> writes: > It's possible that switching it would create bugs elsewhere (there are > over 100 uses of strbuf_detach, so maybe somebody really does want this > NULL behavior), but I tend to think it is just as likely to be fixing > undiscovered bugs. Yeah, I tend to agree. This "format-patch --notes" is obviously a post 1.8.0 topic, and so is the strbuf_detach() clean-up. Let me bookmark this thread in case it hasn't been resolved when I came back from my vacation, so that I won't forget ;-). -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html