Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
> Hi David,
>
> David Aguilar wrote:
>> diff_cmd () {
>> - merge_tool_cmd="$(get_merge_tool_cmd "$1")"
>> - if test -z "$merge_tool_cmd"
>> - then
>> - status=1
>> - break
>> - fi
>> - ( eval $merge_tool_cmd )
>> - status=$?
>> + status=1
>> return $status
>> }
>
> Nit: Why not return 1, instead of setting $status and returning it?
Perhaps because the caller "run_merge_tool" pays attention to
$status that is a global variable?
Have you traced the call chain?
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html