Re: [PATCH] mergetool--lib: Allow custom commands to override built-ins

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi David,

David Aguilar wrote:
>  diff_cmd () {
> -       merge_tool_cmd="$(get_merge_tool_cmd "$1")"
> -       if test -z "$merge_tool_cmd"
> -       then
> -               status=1
> -               break
> -       fi
> -       ( eval $merge_tool_cmd )
> -       status=$?
> +       status=1
>         return $status
>  }

Nit: Why not return 1, instead of setting $status and returning it?

Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]