Hi Junio, Junio C Hamano wrote: >> Junio C Hamano wrote: >>> Yeah, but why change it so much? Wouldn't writing >>> >>> "$GIT_BUILD_DIR/git" >/dev/null >>> if test $? != 1 >>> then >>> : You haven't built git! >>> fi >>> >>> just like the original in 0000 be sufficient?? >> >> Because that emits an ugly >> ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found > > Don't you deserve it? ;-) > > The full message would read > > ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found > error: you do not seem to have built git yet. > > which looks perfectly sensible to me. It makes it clear where on > the filesystem the test script expects your "git", which is an added > benefit. Fair enough- use your version then. Let me know if you want me to submit a revised patch. Ram -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html