Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
> Hi,
>
> Junio C Hamano wrote:
>> Ramkumar Ramachandra <artagnon@xxxxxxxxx> writes:
>>
>>> Hi Junio,
>>>
>>> Junio C Hamano wrote:
>>>> Is this a sufficient replacement for what you removed from 0000?
>>>> Can the BUILD-OPTIONS file exist when your build of git failed?
>>>
>>> Oops, I didn't realize that BUILD-OPTIONS would be written when the
>>> build fails. How about something like this instead:
>>
>> Yeah, but why change it so much? Wouldn't writing
>>
>> "$GIT_BUILD_DIR/git" >/dev/null
>> if test $? != 1
>> then
>> : You haven't built git!
>> fi
>>
>> just like the original in 0000 be sufficient??
>
> Because that emits an ugly
> ./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
Don't you deserve it? ;-)
The full message would read
./test-lib.sh: 54: /home/artagnon/src/git/t/../git: not found
error: you do not seem to have built git yet.
which looks perfectly sensible to me. It makes it clear where on
the filesystem the test script expects your "git", which is an added
benefit.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html