Adam Spiers <git@xxxxxxxxxxxxxx> writes:
Administrivia. Please never deflect direct responses to you with
"Mail-Followup-To" header. I told my mailer to "follow-up" so that I
could give you advice in response, while adding others in the
discussion to Cc so that they do not have to repeat what I said, but
your "Mail-follow-up-to" forced my advice to go to Nguyen, who does
not need one.
> On Tue, Sep 04, 2012 at 08:06:12PM +0700, Nguyen Thai Ngoc Duy wrote:
>> On Sun, Sep 2, 2012 at 7:12 AM, Adam Spiers <git@xxxxxxxxxxxxxx> wrote:
>> > --- a/builtin/add.c
>> > +++ b/builtin/add.c
>> > @@ -273,7 +273,7 @@ static int add_files(struct dir_struct *dir, int flags)
>> > fprintf(stderr, _(ignore_error));
>> > for (i = 0; i < dir->ignored_nr; i++)
>> > fprintf(stderr, "%s\n", dir->ignored[i]->name);
>> > - fprintf(stderr, _("Use -f if you really want to add them.\n"));
>> > + fprintf(stderr, _("Use -f if you really want to add them, or git check-ignore to see\nwhy they're ignored.\n"));
>> > die(_("no files added"));
>> > }
>>
>> String too long (> 80 chars).
>
> You mean the line of code is too long, or the argument to _(), or
> both?
Both.
fprintf(stderr, _("Use -f if you really want to add them, or\n"
"run git check-ignore to see\nwhy they're ignored.\n"));
But in this particular case, I tend to think the additional noise
does not add much value and something the user wouldn't want to see
over and over again (in other words, it belongs to "an advice").
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html