On Mon, Sep 10, 2012 at 6:09 PM, Adam Spiers <git@xxxxxxxxxxxxxx> wrote:
>> > fprintf(stderr, "%s\n", dir->ignored[i]->name);
>> > - fprintf(stderr, _("Use -f if you really want to add them.\n"));
>> > + fprintf(stderr, _("Use -f if you really want to add them, or git check-ignore to see\nwhy they're ignored.\n"));
>> > die(_("no files added"));
>> > }
>>
>> String too long (> 80 chars).
>
> You mean the line of code is too long, or the argument to _(), or
> both? I didn't like this either, but I saw that builtin/checkout.c
> already did something similar twice, and I wasn't sure how else to do
> it. Suggestions gratefully received.
I don't rememeber :( I might mean the output because I missed "\n" in
the middle. At least you can split the string in to at "\n" to make it
resemble output.
>> You should support ignore rules from files and command line arguments
>> too, like ls-files. For quick testing.
>
> You mean --exclude, --exclude-from, and --exclude-per-directory?
> Sure, although I have limited time right now, so maybe these could be
> added in a later iteration?
Sure, no problem. It's not hard to add them anyway (I think).
--
Duy
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html