Jiang Xin <worldhello.net@xxxxxxxxx> writes: > The obsolete LONG_USAGE variable has the following message in it: > > A'\''--B'\''--C'\'' > > And such complex LONG_USAGE message will break xgettext when > extracting l10n messages. But if single quotes are removed from > the message, xgettext works fine on 'git-rebase.sh'. > > Since there is a modern OPTIONS_SPEC variable in use in this > script, it's safe to remove the obsolete USAGE and LONG_USAGE > variables. > > Signed-off-by: Jiang Xin <worldhello.net@xxxxxxxxx> > Reviewed-by: Stefano Lattarini <stefano.lattarini@xxxxxxxxx> I've retitled it and swapped the paragraphs around when queuing this. LONG_USAGE and USAGE are not just "obsolete" but completely unused, so they should be removed, even if xgettext did not have a bug to choke on their contents. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html