Re: [PATCH v2] Fix notes handling in rev-list

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Jukka Lehtniemi <jukka.lehtniemi@xxxxxxxxx> writes:

> Display notes in the rev-list when switch '--notes' is used.
> Also expand notes place holder (%N) in user format.
> Previously rev-list ignored both of these.
>
> Signed-off-by: Jukka Lehtniemi <jukka.lehtniemi@xxxxxxxxx>
> ---
>
> Thanks for your feedback Peff!

If it is an update for some old patch (I am guessing that is the
case from "v2" and "feedback" above), please hint where the
original can be found not to waste reviewers' time.

As "git rev-list -h" does not say anything about "notes", I do not
think this should be even called "Fix"; rather it is "teach rev-list
to show notes with --notes", a new feature.

And as a new feature, "git rev-list -h" should be taught to include
this new option in its output.  I didn't check the documentation but
you may also want to add --notes there, too (hint: grep for "--pretty"
to find where you may need to add the new option).



--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]