On Mon, Jul 9, 2012 at 3:41 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Alex Riesen <raa.lkml@xxxxxxxxx> writes: > >> The original (shell coded) version of the git-clone just used mkdir(1) >> to create the working directories. The builtin changed the mode argument >> to mkdir(2) to 0755, which was a bit unfortunate, as there are use > > A much more important reason why this is a good change (I think you > could even say this is a bugfix) is because directories and files in > the working tree are created with entry.c::create_directories() and > entry.c::create_file(), and they do honour umask settings, and the > top-level of the working tree should be handled the same way, no? Well, the top-level directories of anything are often handled specially, but yes, I agree indeed. Frankly, I wondered why the top-level wasn't created safe_create_leading_directories() or something like that. >> cases where umask-controlled creation is preferred and in any case >> it is a well-known behaviour for new directory/file creation. > > Sign-off? It was an RFC until now :) Signed-off-by: Alex Riesen <raa.lkml@xxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html