Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > You say I'm being irresponsible, I say you are being preoccupied by a > theoretical problem that will not occur, and would not cause any > problems if it does. See how the two implementations are different and think what happens when a user dot sources these two scripts in different order. Callers of __gitdir in one expects it to pay attention to GIT_DIR, callers in the other don't, but you can't have both at the same time in the same shell, can you? It is not theoretical, as you yourself already made it happen. Get over it. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html