On Sun, Jun 10, 2012 at 9:26 AM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >>> I did not see anything like these. >> >> Nor is it needed *right now*. You could release v1.7.11 without any of >> these, and then v1.7.11.1 or even v1.7.12 with a solution; I bet >> __gitdir() would not have changed by that point. > > And by that time on whom are you placing the burden of making sure > they do not diverge? Don't you still realize that you are being > irresponsible? There would be no divergence, that is my bet. There has been only *two* changes since the creation of __gitdir(), and one is in the queue. And even if it does change, there would be *no problem*. Since you have avoided the question, here it goes again: >> It is not even funny to see these two conflicting claims made in a >> single sentence. Given that you are aware that it will cause a huge >> problem to the end users if they diverge, > > What would be that *huge* problem? > > Suppose __gitdir() in git-prompt.sh is never updated again; it won't > be any worst than it is currently, would it? > > Sow what would be this _theoretical_ problem? You say I'm being irresponsible, I say you are being preoccupied by a theoretical problem that will not occur, and would not cause any problems if it does. > In any case, I am tired of your arguing without being constructive, > so let's try again. This is the third option I suggested to you. I could say the same about you :) > Subject: completion: warn people about duplicated function If you want to solve fictional problems, sure go ahead, now the 0 persons that plan to change __git_dir() before v1.7.11.1 would be warned. As long as the real problem is fixed I'm fine with it. Cheers. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html