Re: [PATCHv2] Warnings before rebasing -i published history

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



konglu@xxxxxxxxxxxxxxx writes:

> Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxxxx> a écrit :
>
>> Lucien Kong <Lucien.Kong@xxxxxxxxxxxxxxx> writes:
>>
>>> "git rebase -i" can be very dangerous if used on an already published
>>> history. This code detects that one is rewriting a commit that is an
>>> ancestor of a remote-tracking branch, and warns the user through the
>>> editor. This feature is controlled by a new config key
>>> rebase.checkremoterefs.
>>
>> For the lazy, you could provide an example of result in the commit
>> message. People don't want to review how the patch is written if they
>> disagree with the result.
>
> Right, but wouldn't it be better to put the example in the doc
> git-rebase.txt ?

Why not. In any case, it should be easy to find for reviewers (I had to
dig a little to find the expected value in the tests).

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]