Junio C Hamano <gitster@xxxxxxxxx> a écrit :
+char *mkpathdup(const char *fmt, ...) +{ + char path[PATH_MAX]; + va_list args; + unsigned len; + + va_start(args, fmt); + len = vsnprintf(path, sizeof(path), fmt, args); + va_end(args); + if (len >= sizeof(path)) + return xstrdup(bad_path); + return xstrdup(cleanup_path(path)); +}Hrmph. If a new helper is introduced anyway, wouldn't it be a better idea to get rid of the hardcoded PATH_MAX limitation, perhaps using strbuf_vaddf() or something in the implementation of this function?
Ramsay Jones, what do you think about this ? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html