Junio C Hamano <gitster@xxxxxxxxx> a écrit :
Reading from git_path("HEAD") looked funny, as you may end up reading the "ref: refs/heads/master". Of course that would not compare equal to what you would read from "rebase-merge/amend", and that may be fine for the purpose of your test, but it still looks somewhat funny. As modern rebase is done on a detached HEAD, perhaps it is a good idea to check if the HEAD is detached and return false from this function if that is not the case. I dunno.
On second thoughts, I do not think that checking if HEAD is detached or not is needed, as the part of the code that includes reading can only be called during a rebase interactive, in which case the HEAD can only be detached. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html