Re: [PATCHv6 2/4] t7512-status-help.sh: better advices for git status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



konglu@xxxxxxxxxxxxxxx writes:

> Junio C Hamano <gitster@xxxxxxxxx>:
> ...
>> Please be consistent.  If you want _me_ to pick one, I'd say
>>
>> 	test_when_finished 'rm -fr git' &&
>>         git init git &&
>>         (
>>         	cd git &&
>>                 ... do everything in git subdirectory ...
>> 	)
>>
>> would be my choice.
>
> Btw, should each test be independant with the others?

It would be ideal if you can make them independent with each other,
so that after one fails, later ones do not have to.

> Wouldn't it be better if we remove the "git init git" part?

If you do not need to keep your tests from using the test repository
in $TRASH_DIRECTORY (e.g. "t/trash directory.t7512-status-help"),
you do not have to create a new one with "git init".
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]