Re: [PATCHv6 2/4] t7512-status-help.sh: better advices for git status

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




Junio C Hamano <gitster@xxxxxxxxx> a écrit :

I thought Matthieu always called himself "Matthieu Moy", not the
other way around.  I also inferred the convention used for naming
the mailboxes at your institution to be "$First.$Last@$Domain",
which tells me that perhaps these names are all spelled backwards,
i.e. "$Last $First", which probably goes against the convention used
around you and Matthieu?

Hm, yeah it's spelled backwards, I didn't take notice of that.

+. ./test-lib.sh
+
+. "$TEST_DIRECTORY"/lib-rebase.sh
+
+set_fake_editor
+
+test_expect_success 'status when conflicts unresolved' '
+	git init git &&
+	cd git &&

Eek.

Later tests seem to use

	git init git &&
	(
		cd git &&
                ... everything is done inside git subdirectory ...
	)

with either "test_when_finished 'rm -fr git'" clean-up before the
first "git init git" or "&& rm -fr git" at the end of the && chain.

Please be consistent.  If you want _me_ to pick one, I'd say

	test_when_finished 'rm -fr git' &&
        git init git &&
        (
        	cd git &&
                ... do everything in git subdirectory ...
	)

would be my choice.

Btw, should each test be independant with the others ? We saw that there
are already a lot of tests that are dependant. In this case, can we apply
this method with the parenthesis ?

Wouldn't it be better if we remove the "git init git" part?


--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]