Re: [PATCH] fix many comment typos

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Junio C Hamano wrote:

> Jim Meyering <jim@xxxxxxxxxxxx> writes:
>
>> Use http://github.com/lyda/misspell-check to identify many typos.
>> Culprits identified and fixed automatically using these commands,
>> converting diagnostics to single-quote-safe sed -i commands:
>>
>> git ls-files|misspellings -f -|perl -nl \
>>   -e '/^(.*?)\[(\d+)\]: (\w+) -> "(.*?)"$/ or next;' \
>>   -e '($file,$n,$l,$r)=($1,$2,$3,$4); $q="'\''"; $r=~s/$q/$q\\$q$q/g;'\
>>   -e 'print "sed -i $q${n}s!$l!$r!$q $file"' \
>>  | grep -vE '\.po$|pt_BR' > k
>>
>> Filter out s/seeked/sought/ false positives (they relate to cg-seek):
>>   grep -vE 'seeked' k > j && mv j k
>
> ??
>> diff --git a/Documentation/RelNotes/1.5.4.4.txt
>> b/Documentation/RelNotes/1.5.4.4.txt
>> index 323c1a8..83453db 100644
>> --- a/Documentation/RelNotes/1.5.4.4.txt
>> +++ b/Documentation/RelNotes/1.5.4.4.txt
>> @@ -21,7 +21,7 @@ Fixes since v1.5.4.3
>>
>>   * "git send-email" in 1.5.4.3 issued a bogus empty In-Reply-To: header.
>>
>> - * "git bisect" showed mysterious "won't bisect on seeked tree" error message.
>> + * "git bisect" showed mysterious "won't bisect on sought tree" error message.
>
> ??

Well caught.

I confess.
I manually reverted those two changes and missed the third.
30 lashes.

Perhaps a more palatable change, here and in the other two places:
s/seeked/cg-seek'd/, i.e.,

- * "git bisect" showed mysterious "won't bisect on seeked tree" error message.
+ * "git bisect" showed mysterious "won't bisect on cg-seek'd tree" error message.

Then, if someone does this again, it will be more obvious that
it is not a typo.

If you like that, I'll gladly redo the patch accordingly.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]