Ramkumar Ramachandra wrote: > Jonathan Nieder wrote: >> And >> looking at it from the other side, doesn't using exit mean that you >> cannot be valgrind-clean anyway, since allocations by functions higher >> in the call chain do not get a chance to be freed? > > Good point; save_todo() sets a bad example. For symmetry, should > these two instances of strbuf_release() before die() be removed in a > separate patch? I can't find myself caring much either way. :) A single free() doesn't hurt performance much, so my hunch would be to leave it alone unless some other practical reason to keep or remove the free()s comes up. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html