Hi Jonathan,
Jonathan Nieder wrote:
> Ramkumar Ramachandra wrote:
>> Christian Couder wrote:
>>> [...]
>> if (write_in_full(fd, buf.buf, buf.len) < 0) {
>> strbuf_release(&buf);
>> die_errno(_("Could not write to %s"), todo_file);
>
> [...]
> And
> looking at it from the other side, doesn't using exit mean that you
> cannot be valgrind-clean anyway, since allocations by functions higher
> in the call chain do not get a chance to be freed?
Good point; save_todo() sets a bad example. For symmetry, should
these two instances of strbuf_release() before die() be removed in a
separate patch?
Ram
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html