On Mon, May 7, 2012 at 8:51 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > > >> +# this is NOT a public function; use at your own risk >> +__git_complete () > > The comment is enough to scare away people who might use it and then come > back to complain when this changes its implementation detail, but saying > "This is not X" without saying "This does Y" does not help those who want > to contribute updates to git-completion script. Is there a short and > sweet description of what this is for and/or what this does? No. And this patch is not meant to help those people; I don't even need this, it's not my itch, I just did it because other people complained. Those people would have to scratch their own itch if they want some description of __git_complete (), I only want to reorganize the code and already did more than my fair share. -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html