Zbigniew Jędrzejewski-Szmek <zbyszek@xxxxxxxxx> writes: >> +test_expect_success 'push --progress shows progress to non-tty' ' >> + cd "$ROOT_PATH"/test_repo_clone && >> + test_commit progress && >> + git push --progress 2>&1 | tee output && >> + grep "^To http" output && >> + grep "^Writing objects" output >> +' >> + > I understand that test_i18ngrep is not necessary, because pack-objects.c > is not internationalized. But wouldn't it make sense to use > test_i18ngrep in preparation, so that tests don't have to be modified > later on? In this test, we are not interested in making sure the progress output is properly localized. I'd rather see it keep using grep and if you really care, run "git push" under "LANG=C LC_ALL=C" or something reliable instead. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html