On 05/01/2012 10:43 AM, Jeff King wrote:
> -test_expect_success TTY 'quiet push' '
> +test_expect_success TTY 'push shows progress when stderr is a tty' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit noisy &&
> + test_terminal git push 2>&1 | tee output &&
> + grep "^Writing objects" output
> +'
> +
> +test_expect_success TTY 'push --quiet silences status and progress' '
> cd "$ROOT_PATH"/test_repo_clone &&
> test_commit quiet &&
> - test_terminal git push --quiet --no-progress 2>&1 | tee output &&
> + test_terminal git push --quiet 2>&1 | tee output &&
> test_cmp /dev/null output
> '
>
> +test_expect_success TTY 'push --no-progress silences progress but not status' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit no-progress &&
> + test_terminal git push --no-progress 2>&1 | tee output &&
> + grep "^To http" output &&
> + ! grep "^Writing objects"
! grep "^Writing objects" output
> +'
> +
> +test_expect_success 'push --progress shows progress to non-tty' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit progress &&
> + git push --progress 2>&1 | tee output &&
> + grep "^To http" output &&
> + grep "^Writing objects" output
> +'
> +
I understand that test_i18ngrep is not necessary, because pack-objects.c
is not internationalized. But wouldn't it make sense to use
test_i18ngrep in preparation, so that tests don't have to be modified
later on?
-
Zbyszek
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html