Nguyen Thai Ngoc Duy wrote: > 2012/4/25 Junio C Hamano <gitster@xxxxxxxxx>: >>> + strbuf_addf(timebuf, >>> + Q_("%lu year ago", "%lu years ago", (diff + 183) / 365), >>> + (diff + 183) / 365); >>> } >> >> This is just a tangent, but could we possibly come here and say "1 year >> ago"? > > Nice catch. Singular form here is unnecessary. I think Junio meant Q_("1 year ago", "%lu years ago", ...) That sound reasonable to me. My only worry is a small one: what happens if we want to change the %lu to some other format specifier some day? Will xgettext be smart enough to let translators know without the msgid changing? -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html