2012/4/25 Junio C Hamano <gitster@xxxxxxxxx>: >> /* Give years and months for 5 years or so */ >> if (diff < 1825) { >> ... >> } >> /* Otherwise, just years. Centuries is probably overkill. */ >> - snprintf(timebuf, timebuf_size, "%lu years ago", (diff + 183) / 365); >> - return timebuf; >> + strbuf_addf(timebuf, >> + Q_("%lu year ago", "%lu years ago", (diff + 183) / 365), >> + (diff + 183) / 365); >> } > > This is just a tangent, but could we possibly come here and say "1 year > ago"? Nice catch. Singular form here is unnecessary. If you plan to revert that, please put a comment so nobody will attempt to convert it to Q_() again next time while searching for possible candidates. -- Duy -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html