On Fri, Apr 13, 2012 at 9:30 PM, Jonathan Nieder <jrnieder@xxxxxxxxx> wrote: > Jonathan Nieder wrote: > >> In other words, how about something like this? Tests left as an exercise >> to the interested reader. > > ... and here's a simpler way to spell it. > > -- >8 -- > Subject: completion: do not add trailing space when completing --exec-path > > --exec-path looks like to the completion script like an unambiguous > successful completion, but it is wrong. The user could be trying to > do > > git --exec-path; # print name of helper directory > > or > > git --exec-path=/path/to/alternative/helper/dir <subcommand> > > so the most helpful thing to do is to leave out the trailing space and > leave it to the operator to type an equal sign or carriage return > according to the situation. > > Reported-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> > Signed-off-by: Jonathan Nieder <jrnieder@xxxxxxxxx> > --- > contrib/completion/git-completion.bash | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash > index 31f714da..d2109897 100755 > --- a/contrib/completion/git-completion.bash > +++ b/contrib/completion/git-completion.bash > @@ -2639,6 +2639,7 @@ _git () > --bare > --version > --exec-path > + --exec-path= > --html-path > --work-tree= > --namespace= > -- > 1.7.10 I don't understand, the commit message doesn't match what the patch actually does. In fact, this is the exact patch I sent, is it not? -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html