All other options that accept an argument are completed this way, plus, the '--foo bar' format doesn't seem to work correctly at the moment. Signed-off-by: Felipe Contreras <felipe.contreras@xxxxxxxxx> --- contrib/completion/git-completion.bash | 2 +- t/t9902-completion.sh | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash index 6a8cf9f..efed24a 100755 --- a/contrib/completion/git-completion.bash +++ b/contrib/completion/git-completion.bash @@ -2638,7 +2638,7 @@ _git () --git-dir= --bare --version - --exec-path + --exec-path= --html-path --info-path --work-tree= diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index f2075af..fd2ed3e 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh @@ -90,7 +90,7 @@ test_expect_success 'double dash "git" itself' ' --git-dir= --bare Z --version Z - --exec-path Z + --exec-path= --html-path Z --info-path Z --work-tree= @@ -119,7 +119,7 @@ test_expect_success 'double dash "git checkout"' ' test_expect_success 'general options' ' test_completion "git --ver" "--version " && test_completion "git --hel" "--help " && - test_completion "git --exe" "--exec-path " && + test_completion "git --exe" "--exec-path=" && test_completion "git --htm" "--html-path " && test_completion "git --pag" "--paginate " && test_completion "git --no-p" "--no-pager " && -- 1.7.10.1.g1f19b8.dirty -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html