Junio C Hamano <gitster@xxxxxxxxx> writes: > Felipe Contreras <felipe.contreras@xxxxxxxxx> writes: > >> Do I need to resend the patch? > > Not necessarily. If you can eyeball what is queued on 'pu' and gave me an > Ack (or send a replacement with "You stupid, you amended it wrong!") that > should be sufficient. Actually, can we have a follow-up patch to add in-code comment before the _get_comp_words_by_ref shell function in t9902 to explain why the test overrides this implementation detail? The script being tested will need to maintain _some_ invariants that is expected by this hack in order to keep the test working (or this hack needs to be updated when the updates to the completion script need to break the invariants), but without any explanation on what the invariants are, it is making it hard to others to update the completion script. Thanks. -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html