Re: [PATCH v2] tests: add initial bash completion tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:

> On Thu, Apr 12, 2012 at 8:43 PM, Junio C Hamano <gitster@xxxxxxxxx> wrote:
>> Felipe Contreras <felipe.contreras@xxxxxxxxx> writes:
>>
>>> On Thu, Apr 12, 2012 at 12:57 AM, Felipe Contreras
>>> <felipe.contreras@xxxxxxxxx> wrote:
>>>
>>>> +test_expect_success 'double dash' '
>>>> +       cat >expected <<-\EOF &&
>>>> +       --paginate
>>>> +       --no-pager
>>>> +       --git-dir=
>>>> +       --bare
>>>> +       --version
>>>> +       --exec-path
>>>> +       --html-path
>>>> +       --work-tree=
>>>> +       --namespace=
>>>> +       --help
>>>> +       EOF
>>>> +       test_completion "git --"
>>>
>>> There's a mistake here ^.
>>
>> Yeah, good eyes!  ... ah, wait, it is your bug ;-)
>
> Not my eyes, further tests =/
>
> Do I need to resend the patch?

Not necessarily.  If you can eyeball what is queued on 'pu' and gave me an
Ack (or send a replacement with "You stupid, you amended it wrong!") that
should be sufficient.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]