Re: [PATCH v2 3/8] gitweb: Extract print_sidebyside_diff_lines()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 29 Mar 2012, Michał Kiedrowicz wrote:
> Jakub Narebski <jnareb@xxxxxxxxx> wrote:
> > On Fri, 23 Mar 2012, Michał Kiedrowicz wrote:

> > > This is a preparation patch for diff refinement highlightning.  It should
> > > not change the gitweb output, but it slightly changes its behavior.
> > > Before this commit, context is printed on the class change. Now, it'it
> > > printed just before printing added and removed lines.
> > 
> >                                                       , and at the end
> >   of chunk.

Please don't forget to add that information.  I was wondering about this,
and checked code that it works all right.

> > IMVHO such change is irrelevant.

This refers to "but it slightly changes its behavior", which might be
not clear from the position of this sentence.

> > Acked-by: Jakub Narębski <jnareb@xxxxxxxxx>
> 
> Thanks.

-- 
Jakub Narebski
Poland
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]