Sorry for the delay since my last message, it's been a busy week ;).
On Thu, Mar 22, 2012 at 01:46:34PM +0100, Jakub Narebski wrote:
> ...if not for the fact that control flow changes from using conditional
> and early return to [longjump] "exception" based one. That is why
> I think it would be better to put tests and refactoring in a commit
> separate from adding If-Modified-Since handling to 'snapshot' action.
I'll be sending along three patches. The second and third are the
ones you discuss above. The first is a teensy patch to add `Status`
output to non-304 calls to git_feed(). Without it you'd have to get a
bit more creative in the test suite. If the status lines were left
out intentionally, let me know, and I'll come up with another
condition for those tests.
The second patch refactors and tests git_feed(), and the third patch
adds i-m-s support to git_snapshot() with associated tests.
Changes since v3:
* Patch 1/3 is completely new.
* Split previous patch into 2/3 and 3/3.
* Conditionals in 3/3 to avoid 404-ing on non-commits like v1.7.6^{tree}.
* Added testing to both 2/3 and 3/3.
* Reworked commit messages.
Cheers,
Trevor
--
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
Attachment:
signature.asc
Description: OpenPGP digital signature